chore(deps): update dependency polyfill to 10.7.2#6149
Conversation
thomhurst
added
dependencies
Up to standards ✅🟢 Issues
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Verdict: LGTM — straightforward patch dependency bump, safe to merge.
Change Summary
Single-line version bump in :
-<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>
+<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>Assessment
Correctness: The upstream patch (#552) fixes a real bug — incorrect variant bits in the Guid.CreateVersion7 polyfill for .NET 8, where the RFC 9562/IETF variant bits weren't being set correctly. This is a correctness fix worth taking.
Scope: The change is appropriately minimal — only the pinned version constant is updated. No TUnit logic is touched.
Risk: Very low. Polyfill is a compile-time source-generator package; it emits helper types rather than shipping runtime DLLs, so there is no binary compatibility surface to worry about. The fix narrows to one polyfill method that most projects won't call in tests, and the change itself is a bug-fix (making output more correct), not a breaking API change.
No prior review comments were open on this PR to verify; Codacy also reports 0 issues.
Auto-merge is already enabled — no action required.
There was a problem hiding this comment.
Code Review
Verdict: LGTM — straightforward patch dependency bump, safe to merge.
Change Summary
Single-line version bump in TUnit.Core/TUnit.Core.targets:
-<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>
+<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>Assessment
Correctness: The upstream patch (#552) fixes a real bug — incorrect variant bits in the Guid.CreateVersion7 polyfill for .NET 8, where RFC 9562/IETF variant bits were not being set correctly. This is a meaningful correctness fix worth taking.
Scope: The change is appropriately minimal — only the pinned version constant is updated. No TUnit logic is touched.
Risk: Very low. Polyfill is a compile-time source-generator package; it emits helper types rather than shipping runtime DLLs, so there is no binary compatibility surface to worry about. The fix narrows to one polyfill method that most projects will not call in tests, and the change is a bug-fix (making output more correct), not a breaking API change.
No prior review comments were open on this PR to verify; Codacy also reports 0 issues.
Auto-merge is already enabled — no action required.
2 participants
This PR contains the following updates:
10.7.1→10.7.2Release Notes
SimonCropp/Polyfill (Polyfill)
v10.7.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.