fix: ship pre-built dist for npm install -g from GitHub#6
Merged
Conversation
Remove dist/ from .gitignore and commit built files so that npm install -g thompsonson/codeburn#<tag> works without needing tsup available in the install environment. Drop prepare script (kept prepublishOnly for registry publishes). Bump to 0.9.1-thompsonson.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/from.gitignoreand commit pre-built filespreparelifecycle script (keptprepublishOnlyfor registry publishes)0.9.1-thompsonson.2Why
npm install -g thompsonson/codeburn#<tag>clones the repo and runs lifecycle scripts, buttsup(a devDependency) is not reliably available in that environment. Shipping the builtdist/avoids the build step at install time entirely.Test plan
npm install -g thompsonson/codeburn#v0.9.1-thompsonson.2completes without errorcodeburn --versionreturns0.9.1-thompsonson.2