Conversation
…o 1.24 - Update Dockerfile to use golang:1.24-alpine - Update GitHub Actions workflows to use Go 1.24.x - Update action versions (checkout@v4, setup-go@v5) - Fix YAML syntax errors in main.yml workflow - Fix Go 1.24 compatibility issues in output.go - Maintain all existing functionality including custom CA support
…specific error details
|
🏷️ [bumpr] |
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to Go 1.24 and introduces changes to support custom CA certificates, inline PEM content for client certificates, and updates to CI/CD workflows.
- Update Go version in go.mod, Dockerfile, and GitHub workflows.
- Refactor client authentication handling to support an additional CA field and mixed inline/file path PEM content.
- Update output functions to use Sprint instead of Sprintf and improve error messages in configuration loading.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| output/output.go | Changed formatting calls from Sprintf to Sprint where no formatting is needed. |
| main.go | Updated flag definitions and modified the BuildClientAuth call to include custom CA. |
| go.mod & Dockerfile | Upgraded Go version to 1.24. |
| config/config.go & config_test.go | Enhanced error messages with examples and added tests for YAML parsing failures. |
| client/* (including client.go) | Refactored client certificate processing, added support for inline CA PEM content, and updated tests. |
| README.md | Updated documentation for client authentication options using inline PEM or file paths. |
| .github/workflows/* | Updated action versions and configuration to support Go 1.24. |
| .vscode/settings.json | Added SonarLint connected project settings. |
Comments suppressed due to low confidence (2)
client/client.go:21
- The custom VerifyPeerCertificate callback bypasses all verification by always returning nil. Confirm that this is only activated in insecure contexts to avoid potential security risks.
VerifyPeerCertificate: func(rawCerts [][]byte, verifiedChains [][]*x509.Certificate) error { /* ... */ return nil }
output/output.go:40
- Switching from Sprintf to Sprint removes any formatting capabilities. Please verify that no formatting placeholders are needed in the printed output.
fmt.Fprintln(bo.Out, color.New(c).Sprint(txt))
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64. Fixes #63 Fixes #59
Updates to Go 1.24.