attachment (images) with wrong url

[vangual]

We can successfully upload attachments (pictures) to the myFAQ installation but as soon as we try to add the uploaded picture in an FAQ entry text the following happens:
In the Dialog "Bild einfügen/bearbeiten", Section "Allgemein", Field "Adresse". Click on the "Durchsuchen"-Button. Picture gets selected. Link is automatically filled in but in a wrong way:

1. Generated Link does not contain the httpS:// prefix, just a http:// one.
2. Generated Link contains parts of the filesystem path:
   Example:
   http://correct.hostname.here/var/www/our_faq/images/Lightning.png
   When we manually correct the link in the editbox to the following the picture works:
   https://correct.hostname.here/our_faq/images/Lightning.png

[thorsten]

That's an issue in the bundled Image Manager component, it should be fixed in admin/editor/plugins/ajaxfilemanager/inc/function.base.php at line 492

[rzw]

Here's a fix for line 492 which hopefully works for all possible installation paths. But I've only tested a phpMyFAQ within a domain subdirectory.

// 492 original:    return "http://" .  addTrailingSlash(backslashToSlash($_SERVER['HTTP_HOST'])) . removeBeginingSlash(backslashToSlash($output));
    // Pick up URL up to /admin and exclude /admin  . This is the phpMyFAQ directory
    $rzwbase = strrev(str_replace("nimda/","",stristr(strrev(backslashToSlash($_SERVER['HTTP_REFERER'])),"nimda/")));
    if ($rzwbase == $_SERVER['HTTP_HOST'])    {
    // phpMyFAQ is not in a subdirectory of a domain
       $rzwrest = str_replace($_SERVER['DOCUMENT_ROOT'],"",stristr($output,$_SERVER['DOCUMENT_ROOT']));
    } else {
    // phpMyFAQ is in a subdirectory of a domain
    // extract subdirectory from URL for comparison with path
       $rzwsame = strrchr($rzwbase,"/");
    // extract the rest of URL including file name from file path
       $rzwrest = str_replace($rzwsame,"",substr(backslashToSlash($output),strrpos(backslashToSlash($output),$rzwsame)));
    }
    
    return $rzwbase . $rzwrest ;

[vangual]

I can confirm rzw's patch does fix this issue.

[vangual]

Any chance to get this integrated into the phpMyFAQ distribution of that ajaxfilemanager lib? Or integrated into upstream?

[thorsten]

I will add this for the upcoming 2.7.3 release.

[thorsten]

Fixed with 4625d95

[thorsten]

Broken in 2.8.10