Skip to content

Fix scrollbar position#87

Merged
WhyPenguins merged 2 commits intothoth-tech:mainfrom
UberNomad:fix-scrollbar-position
Sep 26, 2024
Merged

Fix scrollbar position#87
WhyPenguins merged 2 commits intothoth-tech:mainfrom
UberNomad:fix-scrollbar-position

Conversation

@UberNomad
Copy link
Contributor

Description

Fixed the scrollbar bug that was causing the scrollbar to be in the incorrect position when changing between files in the editor.

Fixes # Fix scrollbar jumping to top when switching code files

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Tested with multiple machines on multiple browsers. Specifically a windows and mac machine. On Firefox, Edge, Chrome, Safari.

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

@jessbdeakin
Copy link
Contributor

No changes made so my positive review remains the same.

@UberNomad UberNomad force-pushed the fix-scrollbar-position branch from 4fbc2ff to 7dfd27a Compare September 17, 2024 02:58
Copy link
Contributor

@WhyPenguins WhyPenguins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😃

@WhyPenguins WhyPenguins merged commit 1a88110 into thoth-tech:main Sep 26, 2024
WhyPenguins added a commit that referenced this pull request Sep 26, 2024
 - Completely broke C++ support, this should have been tested.
 - Regression from #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants