Skip to content

Feature audio message#90

Merged
WhyPenguins merged 6 commits intothoth-tech:mainfrom
UberNomad:feature-audio-message
Sep 26, 2024
Merged

Feature audio message#90
WhyPenguins merged 6 commits intothoth-tech:mainfrom
UberNomad:feature-audio-message

Conversation

@UberNomad
Copy link
Contributor

Description

Adds a notification that shows if the user hasn't clicked into the program iFrame window and SplashKit audio functions are being used. Essentially, it reminds the user to click into the Execution Environment so that they can hear the audio playing. This is only a problem on the C++ runtime.

Fixes # Show message to user requesting them to click into the Execution Environment iFrame to get audio working

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Tested in windows and mac

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Copy link
Contributor

@WhyPenguins WhyPenguins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked by Matthew James Harding and Will Saunders during live reviews.
Looks good! 😃

@WhyPenguins WhyPenguins merged commit 2c13f5d into thoth-tech:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants