Conversation
|
Notes from the live review:
Reviewed by Ethan Mark Holley and Mathew James Harding 😄 |
|
Hi Sean, many thanks for your feedback. I have made the changes requested:
This is done if there is no config.cfg file in the directory the program is run from. The program will now create a generic config file, rather than throwing an exception.
the repoURL key in the config map has been removed. Now this gets generated on the fly when it is needed using
This has been done where relevant.
Ditto
This constant has been increased to 256. As discussed, and for future reference, this constraint exists as users entering text can simply hold "right" on the joystick and otherwise create a string of infinite length. So, the max input size should be capped to "something" but this exact value is left at the discretion of the user, and can be arbitrarily changed before compilation. |
WhyPenguins
left a comment
There was a problem hiding this comment.
Looks great! Really nice work 😃
Test menu is a program intended to give arcade-machine users an easier method of compiling & testing their games on local hardware without having to rely on SSHing into the machine to setup & run games.
Test menu is intended to be added to the Arcade's games list as an executable, users then use the existing emulationstation interface to load test menu, which then is used to configure, compile & run games.
The program will setup file structure necessary for the game to be run from emulationstation once emulationstation is restarted. The program assumes the existence of a predefined arcade launch scripts folder. (I.E. /home/deakin/Games/LaunchScripts/)
The program does not support cloning from private repositories, and expects that the user's repo is public.
The program requires a config file called
config.cfgto function, an example is provided below:Type of change
How Has This Been Tested?
Tested locally on my workstation as well as on my raspberrypi4, which is running a locally configured copy of the Thoth-Tech Arcade machine
Checklist: