Skip to content

Add Missing Swingame Functionalities Documentation#536

Merged
WhyPenguins merged 2 commits intothoth-tech:mainfrom
The-0x:main
Sep 30, 2024
Merged

Add Missing Swingame Functionalities Documentation#536
WhyPenguins merged 2 commits intothoth-tech:mainfrom
The-0x:main

Conversation

@The-0x
Copy link
Contributor

@The-0x The-0x commented Aug 22, 2024

Description

Documentation on the functionalities Splashkit is missing from Swingame, an old game engine made by Swinburne University that Splashkit is built off of. This document aims to gather the collection missing functions, primarily focusing on collision logic and a splash screen procedure, to be implemented with a Splashkit animation.

Type of change

  • Documentation (new)

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Contributor

@DarrenSunandar DarrenSunandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation does an excellent job of pointing out and documenting the features that Swingame missing but that Splashkit might provide, with a special emphasis on collision logic. It is easy to understand and has a clear, well-organized structure with separate sections. One of the good things is that the thorough explanations of missing functions include important details that will help with future development.

Copy link
Contributor

@Liquidscroll Liquidscroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good! There are few typos that I'd like to be fixed and a sentence that I'm a little confused about and might need to be changed.

Fixed typos and sentence structures
Copy link
Contributor

@Liquidscroll Liquidscroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This will be a good resource for us to work off as we implement these functions :)

Copy link
Contributor

@WhyPenguins WhyPenguins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good! Hopefully we can start populating the backlog based on this now 😄

@WhyPenguins WhyPenguins merged commit 11785d0 into thoth-tech:main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants