Review "splashkit camera" guide#545
Merged
omckeon merged 4 commits intothoth-tech:mainfrom Oct 9, 2024
Hidden character warning
The head ref may contain hidden characters: "Review-"Splashkit-Camera"-Guide"
Merged
Conversation
Contributor
|
Good job on this tutorial review and mentioning the fixes you've made on this tutorial. |
breezy-codes
approved these changes
Sep 9, 2024
Jinx-means-jinx
approved these changes
Sep 22, 2024
omckeon
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tutorial review of this tutorial has been completed. You have run the code in this tutorial to ensure that it works properly and outputs the results. Fixed an issue in Python code where the wrong number of parameters were passed when fill_rectangle() was called, removed extra parameters, made sure that C# used a top-level statement style, and made sure that the style was consistent with other languages, changed some text descriptions to more clearly express the relationship between game coordinates and screen coordinates, And how to achieve dynamic effects through camera movement.