docs: project-tasks-list migration component review#563
Open
washyking wants to merge 5 commits intothoth-tech:mainfrom
Open
docs: project-tasks-list migration component review#563washyking wants to merge 5 commits intothoth-tech:mainfrom
washyking wants to merge 5 commits intothoth-tech:mainfrom
Conversation
|
You did some work, but are there any interactions involved? I think you should add some Component outcomes and interactions in your component review. |
Author
Just updated the interactions and component outcomes section. The bottom section "Post-migration" is being left for my review and eventually the photo of the completed task @XinHuang1112 |
|
Good job, Alvin. I think this should be fine now. |
XinHuang1112
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a component review markdown for ./src/app/tasks/project-tasks-list/project-tasks-list.coffee
Type of change
Documentation (update or new)