Closed
Conversation
removed the git diff comments left over from rebasing to 9.x from development
aNebula
reviewed
Sep 17, 2024
| end | ||
|
|
||
| create_table "comments_read_receipts", charset: "utf8", collation: "utf8_unicode_ci", force: :cascade do |t| | ||
| create_table "comments_read_receipts", charset: "utf8mb3", collation: "utf8mb3_unicode_ci", force: :cascade do |t| |
There was a problem hiding this comment.
How come there's a mixture of utf8mb3_unicode_ci and utf8mb4_general_ci ?
Author
There was a problem hiding this comment.
Originally there were uft8 as the charset, sql then changed the old entries to uft8mb3, this was as it is outdated and they wish to use the uft8 shorthand elsewhere for their new versions. Any new table generated now uses the uft8mb4 charset
@sammyrolfe - this PR has been updated and merge conflict resolved - can you please review this one more time? |
|
@DudeUnleashed are these already included in the PRs that came next? Otherwise please open upstream PR against https://github.com/doubtfire-lms/doubtfire-api/tree/new/course-flow. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Created entities Course. This will allow access to various information relating to courses for the Courseflow component of OnTrack. Various GET, POST, PUT and DELETE endpoints created and implemented, with appropriate tests.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: