Closed
Conversation
removed the git diff comments left over from rebasing to 9.x from development
merging broken branches
|
Tested all endpoints, working ok. |
13 tasks
|
Is this included in PR 42? Should this be closed? |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the first iteration of the Unit Definition API which will be used for courseflow, this stores the base components of a unit, and will be used to group the different units under a specific Unit Definition. One of the tests fails at the moment, this is by design as the change to the Unit table has not been made yet, therefore it cannot pull the required information for the test to pass.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
In the api you can run the following command to run my tests

bundle exec test test/api/courseflow/unit_definition_test.rb
Checklist:
If you have any questions, please contact @macite or @jakerenzella.