Skip to content

Feature/unitdefinition#42

Closed
DudeUnleashed wants to merge 9 commits intothoth-tech:9.xfrom
DudeUnleashed:feature/unitdefinition
Closed

Feature/unitdefinition#42
DudeUnleashed wants to merge 9 commits intothoth-tech:9.xfrom
DudeUnleashed:feature/unitdefinition

Conversation

@DudeUnleashed
Copy link

@DudeUnleashed DudeUnleashed commented Sep 16, 2024

Description

This PR includes the first iteration of the Unit Definition API which will be used for courseflow, this stores the base components of a unit, and will be used to group the different units under a specific Unit Definition. One of the tests fails at the moment, this is by design as the change to the Unit table has not been made yet, therefore it cannot pull the required information for the test to pass.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

In the api you can run the following command to run my tests
bundle exec test test/api/courseflow/unit_definition_test.rb
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

If you have any questions, please contact @macite or @jakerenzella.

@sammyrolfe
Copy link

Tested all endpoints, working ok.

@aNebula aNebula mentioned this pull request Oct 14, 2024
13 tasks
@aNebula
Copy link

aNebula commented Oct 14, 2024

Is this included in PR 42? Should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants