Conversation
Signed-off-by: washyking <maiblefive201@gmail.com>
Signed-off-by: washyking <maiblefive201@gmail.com>
Signed-off-by: washyking <maiblefive201@gmail.com>
Signed-off-by: washyking <maiblefive201@gmail.com>
Signed-off-by: washyking <maiblefive201@gmail.com>
|
Hi @washyking , I have verified your code locally and it is working as expected. This feature is really good addition to OnTrack as a whole. Approving this PR. |
s223552468
left a comment
There was a problem hiding this comment.
Hi @washyking i accessed the code locally and as stated its working properly by creating a API client with panopto and integrating with Ontrack. Great work Keep it up! Panopto Video Integration with Ontrack will become a great help for Future Students!
aNebula
left a comment
There was a problem hiding this comment.
@washyking Why was the Gemfile.lock and db/schema.rb deleted? I think this needs to be fixed, otherwise it'll break the app.
Once this is done, please open upstream PR against https://github.com/doubtfire-lms/doubtfire-api/tree/8.0.x |
I deleted it because it duplicated when i ran my code |
|
@washyking please revert deletion of these files - deletion should not be in your change set |
Fixed file deletion from comit |
|
Please open a upstream PR against https://github.com/doubtfire-lms/doubtfire-api/tree/9.x |
PR opened doubtfire-lms#456 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
bundle installon the branchYOUR_CLIENT_IDandYOUR_CLIENT_SECRETChecklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have created or extended unit tests to address my new additions
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
If you have any questions, please contact @macite or @jakerenzella.