Migrate/unit ilo edit modal#226
Conversation
|
The migration of the timeout component from AngularJS and CoffeeScript to Angular 17 and TypeScript is well-executed. |
|
Some of your form elements still contain bootstrap classes such as You can also align the buttons to the right of the modal by setting the align property to end: <mat-dialog-actions align="end"> |
| </div> | ||
| <div mat-dialog-content> | ||
| <div fxLayout="row" fxLayoutAlign="start start" style="margin-bottom: 0" required> | ||
| <div fxFlex="20%" style="text-align: right; font-weight: bold; margin-right: 32px"> |
There was a problem hiding this comment.
Visually everything looks good and working well
Few things you'll need to change is swapping out the hardcoded styles into tailwind classes. You can find the corresponding classes for each style by searching the style, such as text-align: right followed with tailwind, and the top link should give you a list of examples for you the match the styles
Description
This task migrates the
unit-ilo-edit-modalcomponent from CoffeeScript to TypeScript. This modal is used to add or edit learning outcomes that correspond to each unit, usingOutcomeLearningServiceto associate it with a certain unit ID. The modal displays the title of the ILO, the abbreviation, and its description.Type of change
How Has This Been Tested?
atutorand select any unit.Previous modal display (edit mode)
Post-migration modal display (new, edit, and results)
Testing Checklist:
Checklist: