Skip to content

Migrate/unit ilo edit modal#226

Open
ivanjustin83 wants to merge 5 commits intothoth-tech:developmentfrom
ivanjustin83:migrate/unit-ilo-edit-modal
Open

Migrate/unit ilo edit modal#226
ivanjustin83 wants to merge 5 commits intothoth-tech:developmentfrom
ivanjustin83:migrate/unit-ilo-edit-modal

Conversation

@ivanjustin83
Copy link

@ivanjustin83 ivanjustin83 commented Aug 5, 2024

Description

This task migrates the unit-ilo-edit-modal component from CoffeeScript to TypeScript. This modal is used to add or edit learning outcomes that correspond to each unit, using OutcomeLearningService to associate it with a certain unit ID. The modal displays the title of the ILO, the abbreviation, and its description.

Type of change

  • Frontend Migration

How Has This Been Tested?

  • Log in as atutor and select any unit.
  • Go to the administration section of the unit, and then select the Learning Outcomes subtab.
  • Either press the Add Outcome button or any pre-existing ILO. The former will create a blank ILO; the latter should display the ILO data.
  • Click on save and the Learning Outcomes list should update itself.

Previous modal display (edit mode)

Initial ILO pre-migration

Post-migration modal display (new, edit, and results)

post-migration modal new
post-migration modal edit
post-migration modal result

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@AusBruce
Copy link

AusBruce commented Aug 7, 2024

The migration of the timeout component from AngularJS and CoffeeScript to Angular 17 and TypeScript is well-executed.
The component benefits from modern Angular features, improved performance, and enhanced maintainability.
Great job!

@b0ink
Copy link

b0ink commented Aug 20, 2024

Some of your form elements still contain bootstrap classes such as form-group, form-control, and col-sm-3, etc. These elements should be replaced with Material Form Field components.

You can also align the buttons to the right of the modal by setting the align property to end:

<mat-dialog-actions align="end">

</div>
<div mat-dialog-content>
<div fxLayout="row" fxLayoutAlign="start start" style="margin-bottom: 0" required>
<div fxFlex="20%" style="text-align: right; font-weight: bold; margin-right: 32px">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually everything looks good and working well

Few things you'll need to change is swapping out the hardcoded styles into tailwind classes. You can find the corresponding classes for each style by searching the style, such as text-align: right followed with tailwind, and the top link should give you a list of examples for you the match the styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants