Skip to content

feat: persistent pdf viewer zoom level#228

Closed
b0ink wants to merge 4 commits intothoth-tech:8.0.xfrom
b0ink:feat/persistent-pdf-zoom
Closed

feat: persistent pdf viewer zoom level#228
b0ink wants to merge 4 commits intothoth-tech:8.0.xfrom
b0ink:feat/persistent-pdf-zoom

Conversation

@b0ink
Copy link

@b0ink b0ink commented Aug 5, 2024

Description

This change ensures that zoom levels in the pdf-viewer component persist across different PDFs and user submissions, instead of resetting to the default zoom every time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Login as atutor or aconvenor and select the inbox/explorer tab to view a list of student submissions.
Select one of the submissions and modify the zoom level.
Select a different submission and/or refresh the page to verify that the zoom level remains the same.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@b0ink b0ink force-pushed the feat/persistent-pdf-zoom branch from 12f1aab to 52899d4 Compare September 28, 2024 07:19
@b0ink
Copy link
Author

b0ink commented Apr 6, 2025

merged in upstream

@b0ink b0ink closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants