Migrate/project tasks list updated by washyking · Pull Request #263 · thoth-tech/doubtfire-web

washyking · 2024-11-21T04:43:22Z

Description

The purpose of 'project-tasks-list' is to show the tasks that a student has interacted with. Showing the status of the task visually e.g Not started, Completed, Time exceeded etc.

Type of change

This change requires a documentation update
Migration from coffee (angularjs) to Angular 17

How Has This Been Tested?

Login in using avencor user. Select a unit; click the drop down and choose portfolio; choose a student; finally click view progress.

I have tested this code by using the browser and have Screenshots will show comparison between previous and current implementation in various browsers.
#Before:

#After

Testing Checklist:

Tested in latest Chrome
Tested in latest Safari
Tested in latest Firefox

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have requested a review from @macite and @jakerenzella on the Pull Request

Signed-off-by: washyking <maiblefive201@gmail.com>

… component Signed-off-by: washyking <maiblefive201@gmail.com>

… dashboard Signed-off-by: washyking <maiblefive201@gmail.com>

…remove unused no data template Signed-off-by: washyking <maiblefive201@gmail.com>

Signed-off-by: washyking <maiblefive201@gmail.com>

…uest Signed-off-by: washyking <maiblefive201@gmail.com>

Signed-off-by: washyking <maiblefive201@gmail.com>

Shounaks · 2024-11-21T08:58:28Z

incorrect Base Branch , use origin.8.0.x.

washyking · 2024-11-21T09:00:17Z

incorrect Base Branch , use origin.8.0.x.

branch changed

Shounaks

These are the major changes which I forsee. will check in depth in some time.

Shounaks · 2024-11-21T09:06:00Z

src/app/tasks/project-tasks-list/project-tasks-list.component.scss

@@ -0,0 +1,73 @@
+@import '../../../../build/assets/doubtfire.css';
+
+.project-tasks-list {


Use Tailwind CSS for all the newer components

Just made changes using tailwind in line style and tailwind.config.js

Shounaks · 2024-11-21T09:07:02Z

src/app/projects/project-progress-dashboard/project-progress-dashboard.tpl 2.html

+          <div class="panel-body text-center">
+            <p class="btn-group">
+              <label ng-repeat="grade in grades" ng-if="$index != 4" ng-click="chooseGrade($index)" class="btn btn-default col-sm-3 text-center" ng-model="project.targetGrade" btn-radio="{{$index}}">
+                <grade-icon grade="grade" tooltip="Select a {{grade}} as your target grade" tooltip-append-to-body="true" class="text-{{$index == project.targetGrade ? 'primary' : 'muted'}}"></grade-icon>


use Material Design Tooltips:
https://v6.material.angular.io/components/tooltip/examples

Not sure if its in my scope. I was migrating project-tasks-list to angular so only focused on the component. I think i might have commited extra file for some reason.

Shounaks · 2024-11-21T09:07:30Z

src/app/projects/states/dashboard/directives/student-task-list/student-task-list 2.coffee

+#
+# View a list of tasks
+#
+.directive('studentTaskList', ->


Shouldn't CoffeeScript code be removed? whats happening here?

Not part of my task, I dont why thats there. I will delete the file

Shounaks · 2024-11-21T09:11:37Z

src/app/doubtfire-angularjs.module.ts


 // directive -> component
+DoubtfireAngularJSModule.directive(
+  'projectTasksList',


are you sure that this should be projectTaskList and not fProjectTaskList

just made the change adding f- infront of my component

Signed-off-by: washyking <maiblefive201@gmail.com>

anmol-sainii · 2024-11-26T02:38:30Z

need to fix this issue still-
the text is not fully showing up in the bubble in your version.
Here's what it looks like on the base branch:

And heres what it looks like on your version:

I have tested this on safari and google chrome and firefox and it looks like this on all.

Signed-off-by: washyking <maiblefive201@gmail.com>

washyking · 2024-11-26T05:35:13Z

need to fix this issue still- the text is not fully showing up in the bubble in your version. Here's what it looks like on the base branch: And heres what it looks like on your version:

I have tested this on safari and google chrome and firefox and it looks like this on all.

Thanks for that. I hadnt handled the words wrapping in the tooltip. Now fixed

anmol-sainii · 2024-11-26T09:51:41Z

The text is now wrapping properly. However is pretty hard to read
Here's what your version looks like:

Heres the base branch version

I think it just needs a fill colour perhaps?

washyking · 2024-11-26T13:52:26Z

The text is now wrapping properly. However is pretty hard to read Here's what your version looks like: Heres the base branch version I think it just needs a fill colour perhaps?

Just made a fix contrasting the backgournd more

Signed-off-by: washyking <maiblefive201@gmail.com>

…ashboard.tpl 2.html

…/student-task-list 2.coffee

…ching-period-list.component 2.ts

…finition-editor/task-definition-upload/task-definition-upload.component 2.ts

…finition-editor/task-definition-overseer/task-definition-overseer.component 2.ts

…ching-period-list.component 2.html

…finition-editor/task-definition-resources/task-definition-resources.component 2.html

…finition-editor/task-definition-resources/task-definition-resources.component 3.html

…ching-period-list.component 3.ts

Shounaks · 2024-12-04T02:48:55Z

Review

Thanks @washyking , for this PR. I have gone through the code, and everything looks correct.

Steps to Replicate on local

Login Using Admin
Click on Portfolio
Click on View Progress
Test the component.

Testing the component

Before Hover

After Hover

Everything looks correct, except the glowing letters are a bit hard to read, and something that didnt existed before, as @anmol-sainii , pointed out, this error is still present.

I am approving this, but just make a CSS Patch before pushing it to upstream review.

XinHuang1112 · 2024-12-05T08:37:24Z

I have tested your code on my local machine, and it looks all good. The code changes are all right. I believe you have successfully migrated the project-task-list component.

nodogx · 2024-12-05T08:47:41Z

I have also tested your code by running it on the local device. Everything seems to work. I have reviewed the code as well and everything seems good to go. I approve these changes.

nodogx

Seems good

aNebula · 2024-12-09T08:00:23Z

[ ] @washyking - Please change the glowing letters.
@nodogx and @XinHuang1112 - you have not reviewed properly.

Signed-off-by: washyking <maiblefive201@gmail.com>

washyking · 2024-12-11T01:48:18Z

Glowing letters have been fixed in safari.

Glowing letters fixed in chrome

nodogx

This code looks much better:

Before: (original files before migration)

After Migration:

The glowing letters look so much better; however, its still slightly present. Everything else works as intended. Approving this as the glowing letters, after the fix is barely noticeable. Good Job :)

XinHuang1112 · 2024-12-13T09:35:51Z

Your code logic is essentially consistent with the original logic. I tested your code on my local machine and found that you have resolved the issue with the glowing letters.

I believe you have completed the migration of the project-tasks-list component, so I have approved your PR.

aNebula

Good work @washyking. Please open upstream pull request with these changes against the upstream repo doubtfire-lms/doubtfire-web, branch 8.0.x

washyking · 2025-01-22T08:59:49Z

Good work @washyking. Please open upstream pull request with these changes against the upstream repo doubtfire-lms/doubtfire-web, branch 8.0.x

Opened PR in that branch #277

washyking added 16 commits November 17, 2024 16:19

feat: add task definition upload and resource management components

99f0b50

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: add project tasks list component

a14025f

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: test migration of updated files

fa239ec

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: integrate project tasks list component and update references

59a6361

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: add no data template and improve styling for project tasks list…

e9a4822

… component Signed-off-by: washyking <maiblefive201@gmail.com>

feat: simplify project tasks list component usage in project progress…

946b496

… dashboard Signed-off-by: washyking <maiblefive201@gmail.com>

feat: enhance project tasks list component with improved tooltip and …

80863ec

…remove unused no data template Signed-off-by: washyking <maiblefive201@gmail.com>

feat: rendered tasks list

8e09f23

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: added tooltip and achieving similar styling

bde1a19

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: styling to match current project-tasks-list implementation

a786f2c

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: more styling changes

e1ab0b9

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: all styling and fucntionality match semi finished next pull req…

406e5a4

…uest Signed-off-by: washyking <maiblefive201@gmail.com>

feat: semi rebuild using global styles

b847c9c

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: attempting to bold

cd77d7d

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: boldness achieved additionally deleting old files

04e211a

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: handling safari and firefox selection

6df0315

Signed-off-by: washyking <maiblefive201@gmail.com>

washyking changed the base branch from development to 8.0.x November 21, 2024 08:59

Shounaks suggested changes Nov 21, 2024

View reviewed changes

washyking added 2 commits November 24, 2024 13:30

feat: reference f-project-tasks-list

58c61d5

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: changes made regarding comments in PR

7c15d5a

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: fix comment on PR regarding text not wrapping tooltip

8aa151e

Signed-off-by: washyking <maiblefive201@gmail.com>

feat: colour contrast on tooltip

012e9d7

Signed-off-by: washyking <maiblefive201@gmail.com>

washyking requested a review from Shounaks December 1, 2024 08:09

Delete src/app/api/models/task 2.ts

f6f2996

washyking added 14 commits December 4, 2024 09:53

Delete src/app/api/services/authentication.service 2.ts

c37db66

Delete CHANGELOG 2.md

63cac51

Delete src/app/projects/project-progress-dashboard/project-progress-d…

42af868

…ashboard.tpl 2.html

Delete src/app/projects/states/dashboard/directives/student-task-list…

4c37b62

…/student-task-list 2.coffee

Delete src/app/admin/states/teaching-periods/teaching-period-list/tea…

d1cf42f

…ching-period-list.component 2.ts

Delete src/app/units/states/edit/directives/unit-tasks-editor/task-de…

60e649a

…finition-editor/task-definition-upload/task-definition-upload.component 2.ts

Delete src/app/units/states/edit/directives/unit-tasks-editor/task-de…

7bb7f35

…finition-editor/task-definition-overseer/task-definition-overseer.component 2.ts

Delete src/app/common/file-downloader/file-downloader.service 3.ts

b1bae56

Delete src/app/admin/states/teaching-periods/teaching-period-list/tea…

7086add

…ching-period-list.component 2.html

Delete src/app/common/file-downloader/file-downloader.service 2.ts

9e38c67

Delete src/app/units/states/edit/directives/unit-tasks-editor/task-de…

5ee8e4e

…finition-editor/task-definition-resources/task-definition-resources.component 2.html

Delete src/app/api/services/authentication.service 3.ts

2612a3e

Delete src/app/units/states/edit/directives/unit-tasks-editor/task-de…

b01e6f4

…finition-editor/task-definition-resources/task-definition-resources.component 3.html

Delete src/app/admin/states/teaching-periods/teaching-period-list/tea…

0ac27b3

…ching-period-list.component 3.ts

Shounaks approved these changes Dec 4, 2024

View reviewed changes

XinHuang1112 approved these changes Dec 5, 2024

View reviewed changes

nodogx approved these changes Dec 5, 2024

View reviewed changes

feat: fix glowing letters

fee0719

Signed-off-by: washyking <maiblefive201@gmail.com>

nodogx approved these changes Dec 11, 2024

View reviewed changes

XinHuang1112 approved these changes Dec 13, 2024

View reviewed changes

aNebula self-requested a review December 21, 2024 05:25

aNebula approved these changes Dec 21, 2024

View reviewed changes

washyking mentioned this pull request Jan 22, 2025

Migrate/project tasks list updated #277

Open

11 tasks

		@@ -0,0 +1,73 @@
		@import '../../../../build/assets/doubtfire.css';

		.project-tasks-list {

Conversation

washyking commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Testing Checklist:

Checklist:

Uh oh!

Shounaks commented Nov 21, 2024

Uh oh!

washyking commented Nov 21, 2024

Uh oh!

Shounaks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anmol-sainii commented Nov 26, 2024

Uh oh!

washyking commented Nov 26, 2024

Uh oh!

anmol-sainii commented Nov 26, 2024

Uh oh!

washyking commented Nov 26, 2024

Uh oh!

Shounaks commented Dec 4, 2024

Review

Steps to Replicate on local

Testing the component

Before Hover

After Hover

Everything looks correct, except the glowing letters are a bit hard to read, and something that didnt existed before, as @anmol-sainii , pointed out, this error is still present.

Uh oh!

XinHuang1112 commented Dec 5, 2024

Uh oh!

nodogx commented Dec 5, 2024

Uh oh!

nodogx left a comment

Choose a reason for hiding this comment

Uh oh!

aNebula commented Dec 9, 2024

Uh oh!

washyking commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodogx left a comment

Choose a reason for hiding this comment

Uh oh!

XinHuang1112 commented Dec 13, 2024

Uh oh!

aNebula left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

washyking commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

washyking commented Nov 21, 2024 •

edited

Loading

washyking commented Dec 11, 2024 •

edited

Loading

aNebula left a comment •

edited

Loading