Skip to content

cleanup/create-unit-modal#388

Closed
jtalev wants to merge 1 commit intothoth-tech:9.xfrom
jtalev:cleanup/create-unit-modal
Closed

cleanup/create-unit-modal#388
jtalev wants to merge 1 commit intothoth-tech:9.xfrom
jtalev:cleanup/create-unit-modal

Conversation

@jtalev
Copy link

@jtalev jtalev commented Aug 5, 2025

Description

create-unit-modal was previously migrated to and Angular component called create-new-unit-modal, but the old files and references to those files were not removed when the migration was done. Therefore, I've removed the legacy files and all references.

After:
after

Type of change

  • Cleanup redundant files

How Has This Been Tested?

After deleting the files and references, I observed the create-unit-modal functioning as it did before

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

import 'build/src/app/projects/states/index/index.js';
import 'build/src/app/projects/states/tutorials/tutorials.js';
import 'build/src/app/projects/project-outcome-alignment/project-outcome-alignment.js';
import 'build/src/app/admin/modals/modals.js';
Copy link

@returnMarcco returnMarcco Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking that this was only used in the old implementation of create-unit-modal. I can see that it only contained create-unit-modal in the modals.js file.

@returnMarcco
Copy link

returnMarcco commented Aug 13, 2025

Hi @jtalev,

This is a senior review for your task.

I can see that you've removed the old Coffeescript files and references to them.
I've tested the new component with success, and it behaves and looks as expected. I was unable to find any references to the old files in the codebase or in the bundle via devtools, which is good.

Screenshot 2025-08-13 230620 [Screenshot of the new component after migration]

Well done on the task.

@jtalev jtalev closed this by deleting the head repository Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants