Conversation
returnMarcco
left a comment
There was a problem hiding this comment.
Hey @Pasindufdo98,
Good work on this fix.
The component routes as expected. I've left a suggestion on where to keep the state declaration, but other than that, everything looks good.
Once the feedback is reviewed and requested changes are made I'll approve this PR.
Cheers.
chelaz1234
left a comment
There was a problem hiding this comment.
Hi @Pasindufdo98,
The PR description is clear and well-scoped: it explains what was broken (task viewer routing, task list scrolling, PDF viewer) and what was fixed. The routing fix has been properly implemented and works as expected. Overall, great job!
HasinduWelarathne
left a comment
There was a problem hiding this comment.
Hey @Pasindufdo98 ,
Tested the routing changes and everything works as expected. The task viewer now loads correctly without navigation issues. Code looks clean and aligns well with the existing Angular structure. Great job on fixing this!
Description
This PR fixes multiple issues in the 9.x branch:
After fixing routing issue.

After fixing both routing and UI issues.

Type of change
Corrected the UI-Router state configuration to properly register the units/tasks/viewer state.
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Testing Checklist:
Checklist: