feat: enhance search in courseflow with autocomplete and remove#409
Open
Lolretrorat wants to merge 1 commit intothoth-tech:new/course-flowfrom
Open
feat: enhance search in courseflow with autocomplete and remove#409Lolretrorat wants to merge 1 commit intothoth-tech:new/course-flowfrom
Lolretrorat wants to merge 1 commit intothoth-tech:new/course-flowfrom
Conversation
Author
Duy-Nguyen1104
approved these changes
Sep 10, 2025
Duy-Nguyen1104
left a comment
There was a problem hiding this comment.
Hi Josh. I have fetched your PRs and tested out the behavior regarding searching for unit. Here are the improvements that I confirmed:
- When I search for a unit, the text I enter is used as a filter to find the exact match.
- As I type, a filtered list appears above the search bar.
- I can search using both the code and unit title
Everything is working smoothly. As a future enhancement, we could make the filter more fine-grained (e.g., by level or campus). Overall, great work!
AB-Deakin
approved these changes
Sep 14, 2025
|
Hi @Lolretrorat |
WaelAlahamdi
approved these changes
Sep 20, 2025
Triet-coder
approved these changes
Sep 21, 2025
There was a problem hiding this comment.
Looks good! The courseflow unit search works smooth — autocomplete updates live as I type, and removing units from the list is clean with no weird side effects. I tested add/remove, fast typing, and empty state; no regressions. Maybe just add a small debounce to cut extra calls and a quick test for remove + no-match case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Added enhancement to courseflow unit search including autocomplete of available units that dynamically updates as input updates.
Also added remove units from list functionality
Fixes # (issue)
Type of change
How Has This Been Tested?
AS an admin
IF i input text into a search field
THEN i should see autocomplete suggestions
AND selecting an option should add the unit to the required/elective unit list
AND furhter autocomplete suggestions should not include the unit again
Input sanitization was also verified
Testing Checklist:
Checklist: