Skip to content

Add bitmap, sound effect and music unit tests#64

Merged
WhyPenguins merged 5 commits intothoth-tech:t2-2024from
matt439:add-unit-tests
Sep 30, 2024
Merged

Add bitmap, sound effect and music unit tests#64
WhyPenguins merged 5 commits intothoth-tech:t2-2024from
matt439:add-unit-tests

Conversation

@matt439
Copy link

@matt439 matt439 commented Aug 26, 2024

Description

There is currently only two unit tests: JSON and text. There are many other processes which could be tested such as audio, images. I have created three unit tests which cover bitmaps, sound effects and music. They each perform exhaustive testing of the types including their loading and freeing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Adding the new tests was achieved by running cmake -G "Unix Makefiles" . followed by make when in the /splashkit-core/projects/cmake directory. The tests deliberately cause warning messages to occur in the terminal when they attempt to load non-existent files.

Testing Checklist

  • Tested with sktest
  • Tested with skunit_tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Copy link

@Wills2022 Wills2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matthew,

Thanks for updating the pull. I've re-tested this locally using the instructions you've provided and i'm now able to get the new unit-tests to run.

I noticed that you've already incorporated the other changes i'd requested in the original pull. Otherwise, looks good !

image

Copy link

@Liquidscroll Liquidscroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! I also ran these tests and got the expected output. It's always great to see more thorough testing :)

Copy link

@WhyPenguins WhyPenguins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work 😃

@WhyPenguins WhyPenguins changed the base branch from develop to t2-2024 September 30, 2024 18:54
@WhyPenguins WhyPenguins merged commit a982ee2 into thoth-tech:t2-2024 Sep 30, 2024
@matt439 matt439 deleted the add-unit-tests branch November 1, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants