Add bitmap, sound effect and music unit tests#64
Merged
WhyPenguins merged 5 commits intothoth-tech:t2-2024from Sep 30, 2024
Merged
Add bitmap, sound effect and music unit tests#64WhyPenguins merged 5 commits intothoth-tech:t2-2024from
WhyPenguins merged 5 commits intothoth-tech:t2-2024from
Conversation
Wills2022
approved these changes
Aug 26, 2024
Liquidscroll
approved these changes
Aug 27, 2024
Liquidscroll
left a comment
There was a problem hiding this comment.
Look good to me! I also ran these tests and got the expected output. It's always great to see more thorough testing :)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
There is currently only two unit tests: JSON and text. There are many other processes which could be tested such as audio, images. I have created three unit tests which cover bitmaps, sound effects and music. They each perform exhaustive testing of the types including their loading and freeing.
Type of change
expected)
How Has This Been Tested?
Adding the new tests was achieved by running
cmake -G "Unix Makefiles" .followed bymakewhen in the/splashkit-core/projects/cmakedirectory. The tests deliberately cause warning messages to occur in the terminal when they attempt to load non-existent files.Testing Checklist
Checklist