Fix/change label text throughout codebase#66
Merged
WhyPenguins merged 3 commits intothoth-tech:t2-2024from Sep 30, 2024
Liquidscroll:fix/change-label-text-throughout-codebase
Merged
Fix/change label text throughout codebase#66WhyPenguins merged 3 commits intothoth-tech:t2-2024from Liquidscroll:fix/change-label-text-throughout-codebase
WhyPenguins merged 3 commits intothoth-tech:t2-2024from
Liquidscroll:fix/change-label-text-throughout-codebase
Conversation
Wills2022
approved these changes
Sep 9, 2024
WhyPenguins
approved these changes
Sep 30, 2024
WhyPenguins
left a comment
There was a problem hiding this comment.
Looks good! Just noting that we'll need to update the guides on splashkit.io as well, if someone could add a card for that that'd be awesome 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renamed
label()functions tolabel_element(), all other instances oflabelrelates to the label text, so these have been changed tolabel_text.Here is an image of the UI test running correctly after these modifications:
Context
We need to update SplashKit to resolve a conflict with the label parameter name. In Pascal, 'label' is a reserved keyword, which is causing issues with the current implementation.
I wrote a script to replace all instances of 'label' that were not in a comment to 'label_text'. Then the @param field in the comments for each public function (in interface.h) was modified for each applicable function to match 'label_text'. I then manually modified the
label()function tolabel_element(). Then I reran the translator, and installed skm directly from the /out/ folder. There are some issues, however.At this point I can compile a Pascal program with no problems, but I can't get it to run. It seems to compile despite the Notes and Warnings, so I suspect the issue is with my setup.
EDIT: I have found a fix for this, I will include this in another PR.
Compilation:
Running the program:
Fixes # (issue)
Type of change
How Has This Been Tested?
Compiled a test Hello World program, however this cannot be run do to a linking issue. The fix for this is in progress.
Testing Checklist
Checklist