Conversation
✅ Deploy Preview for splashkit-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hugglesfox
left a comment
hugglesfox
left a comment
There was a problem hiding this comment.
A couple of nit picks in the review comments but looks good!
| @@ -0,0 +1,3 @@ | |||
| ### Fill Triangle | |||
|
|
|||
| The following code demonstrates how to use the Fill_Triangle function to draw a simple red colour -filled triangle. It creates a triangle with specified coordinates and fills it with red color. No newline at end of file | |||
| open_window("Fill triangle Example", 800, 600); | ||
| clear_screen(); | ||
| fill_triangle(COLOR_RED, 100, 100, 200, 200, 300, 100); | ||
| refresh_screen(); | ||
|
|
||
| delay(5000); | ||
|
|
||
| close_all_windows(); | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
The code spacing here is a bit weird. My recommendation would be to group things around the fill_triangle function to emphasize it. E.g.
open_window("Fill triangle Example", 800, 600);
clear_screen();
fill_triangle(COLOR_RED, 100, 100, 200, 200, 300, 100);
refresh_screen();
delay(5000);
close_all_windows();
return 0;
|
Made changes as per the suggesstion given by Hayley. |
omckeon
left a comment
omckeon
left a comment
There was a problem hiding this comment.
Update the file names with the ones we updated in the meeting last week.
And then include a screenshot of the example showing on the Graphics Usage examples page in your PR description.
|
Note for those reviewing usage examples - You need to test this in the browser to show it working there, not just the code separately. (@hugglesfox @s223126445 @sananoureen35 ) |
|
Updated the file names and included the screenshot in PR description. |
5 participants
The following code demonstrates how to use the Fill_Triangle function to draw a simple red colour -filled triangle. It creates a triangle with specified coordinates and fills it with red color.
Here is the screenshot of how the Graphics Usage examples page look like.
