Skip to content

Introduction to json tutorial c# language update#175

Merged
omckeon merged 10 commits intothoth-tech:tutorial-guide-improvementsfrom
Srainyyyy:Introduction-to-JSON-Tutorial-C#-Language-Update
Oct 1, 2024
Merged

Introduction to json tutorial c# language update#175
omckeon merged 10 commits intothoth-tech:tutorial-guide-improvementsfrom
Srainyyyy:Introduction-to-JSON-Tutorial-C#-Language-Update

Conversation

@Srainyyyy
Copy link

@Srainyyyy Srainyyyy commented Sep 9, 2024

I have added C# OOP code to this tutorial, below is a screenshot of the code test:
image

image

clear game_data.json
image

@netlify
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for splashkit-io ready!

Name Link
🔨 Latest commit 86e2b8f
🔍 Latest deploy log https://app.netlify.com/sites/splashkit-io/deploys/66de752b65ee630008e3d5cf
😎 Deploy Preview https://deploy-preview-175--splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Srainyyyy Srainyyyy closed this Sep 11, 2024
@Srainyyyy Srainyyyy reopened this Sep 11, 2024
@netlify
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for splashkit-io ready!

Name Link
🔨 Latest commit 772d88b
🔍 Latest deploy log https://app.netlify.com/sites/splashkit-io/deploys/66fb9ee81788f800080398f7
😎 Deploy Preview https://deploy-preview-175--splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@s223126445 s223126445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutorial Review - Introduction to json tutorial c# language update
Good work, both the codes are working fine.But please update the OOP code similar to the top-level statement.
Screenshots of code test:
Opp_test1
OOP_test2

{
public static void Main()
{
// Define the file path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove these comments in the OOP version as there is no comments in the C++ or the C# top level statement version. So the comments within this OOP one look really out of place.

{
public static void Main()
{
// Define the file path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar in this one, the comments look out of place when comparing to the C++ and C# top level statement versions.

Copy link

@breezy-codes breezy-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code runs correctly and looks good, although the comments within the code need to be removed so that they match with how the code is in the C++ and C# top level versions.

Copy link

@breezy-codes breezy-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, everything works correctly.

@omckeon omckeon changed the base branch from main to tutorial-guide-improvements October 1, 2024 06:50
@netlify
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for tutorials-splashkit-io ready!

Name Link
🔨 Latest commit 772d88b
🔍 Latest deploy log https://app.netlify.com/sites/tutorials-splashkit-io/deploys/66fb9ee8e9c75d0007297db1
😎 Deploy Preview https://deploy-preview-175--tutorials-splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@omckeon omckeon force-pushed the Introduction-to-JSON-Tutorial-C#-Language-Update branch from fd995c6 to 772d88b Compare October 1, 2024 07:04
@omckeon omckeon merged commit 4855ae0 into thoth-tech:tutorial-guide-improvements Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants