Skip to content

Add C# OOP to "Using Animations in SplashKit" tutorial#194

Merged
omckeon merged 16 commits intothoth-tech:tutorial-guide-improvementsfrom
oexellbruce:animations_cs_update
Oct 1, 2024
Merged

Add C# OOP to "Using Animations in SplashKit" tutorial#194
omckeon merged 16 commits intothoth-tech:tutorial-guide-improvementsfrom
oexellbruce:animations_cs_update

Conversation

@oexellbruce
Copy link

@oexellbruce oexellbruce commented Sep 20, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration.

  • Tested in latest Chrome
  • Tested in latest Firefox
  • npm run build
  • npm run preview

Checklist

If involving code

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request.

  • Added:
    • N/A
  • Modified:
    • src/content/docs/guides/Animations/0-using-animations.mdx

@netlify
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for splashkit-io ready!

Name Link
🔨 Latest commit 2d77a82
🔍 Latest deploy log https://app.netlify.com/sites/splashkit-io/deploys/66fba81ce8fb280008136079
😎 Deploy Preview https://deploy-preview-194--splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oexellbruce oexellbruce marked this pull request as ready for review September 25, 2024 14:05
Copy link

@NidhishaPahade NidhishaPahade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. The code functionality is as expected and is equivalent to the cpp version.

@omckeon omckeon changed the base branch from main to tutorial-guide-improvements October 1, 2024 07:39
@netlify
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for tutorials-splashkit-io ready!

Name Link
🔨 Latest commit 2d77a82
🔍 Latest deploy log https://app.netlify.com/sites/tutorials-splashkit-io/deploys/66fba81c08cd5800075765b8
😎 Deploy Preview https://deploy-preview-194--tutorials-splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@omckeon omckeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work making the OOP code as Object-Oriented as possible! Very easy to review :)

@omckeon omckeon merged commit 47c5970 into thoth-tech:tutorial-guide-improvements Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants