Skip to content

Add C# Language Tabs to "Drawing using Procedures" Guide#198

Merged
omckeon merged 22 commits intothoth-tech:tutorial-guide-improvementsfrom
NidhishaPahade:drawingprocedures
Oct 2, 2024
Merged

Add C# Language Tabs to "Drawing using Procedures" Guide#198
omckeon merged 22 commits intothoth-tech:tutorial-guide-improvementsfrom
NidhishaPahade:drawingprocedures

Conversation

@NidhishaPahade
Copy link

@NidhishaPahade NidhishaPahade commented Sep 20, 2024

Description

Added C# Top level and OOP code to the "Drawing using Procedures" tutorial.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration.

  • Tested in latest Chrome
  • Tested in latest Firefox
  • npm run build
  • npm run preview

Checklist

If involving code

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

If modified config files

  • I have checked the following files for changes:
    • package.json
    • astro.config.mjs
    • netlify.toml
    • docker-compose.yml
    • custom.css

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request.

  • Added:
    • NA
  • Modified:
    • src/content/docs/guides/Graphics/0-drawing-using-procedures.mdx

Additional Notes

Screenshots of the code running succesfully:

Screenshot 2024-09-20 190123 Screenshot 2024-09-20 190223 Screenshot 2024-09-20 190327 Screenshot 2024-09-20 190422

@netlify
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for splashkit-io ready!

Name Link
🔨 Latest commit 2b4a40c
🔍 Latest deploy log https://app.netlify.com/sites/splashkit-io/deploys/66fcec5ea7c9730008313c62
😎 Deploy Preview https://deploy-preview-198--splashkit-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@omckeon omckeon changed the title Added Language Updates Add C# Language Tabs to "Drawing using Procedures" Guide Sep 22, 2024
@omckeon
Copy link

omckeon commented Sep 22, 2024

@NidhishaPahade Please update the PR description to use the template from this page. With screenshots put at the end.

Copy link

@oexellbruce oexellbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both OOP code blocks could have Window window = new Window(...
Lines 74 and 202.

Copy link

@oexellbruce oexellbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

  • Tested in latest Chrome
  • Tested in latest Firefox
  • npm run build
  • npm run preview

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request.

  • Added:
    • N/A
  • Modified:
    • src/content/docs/guides/Graphics/0-drawing-using-procedures.mdx

Looks good, great work!

@omckeon omckeon changed the base branch from main to tutorial-guide-improvements October 2, 2024 06:47
@omckeon omckeon merged commit 4cbf0fc into thoth-tech:tutorial-guide-improvements Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants