Skip to content

Added various beyond SK programs#338

Merged
omckeon merged 8 commits intothoth-tech:add/beyond-splashkitfrom
SimonRhook:beyond-splashkit
Dec 17, 2024
Merged

Added various beyond SK programs#338
omckeon merged 8 commits intothoth-tech:add/beyond-splashkitfrom
SimonRhook:beyond-splashkit

Conversation

@SimonRhook
Copy link

@SimonRhook SimonRhook commented Dec 10, 2024

Description

Added various programs to compare SplashKit vs No SplashKit. These programs demonstrate the abstraction that takes place within the SplashKit SDK to hide away complexity. The No SplashKit versions essentially show what is happening in the back end of SplashKit when various functions are called.

Type of change

Please delete options that are not relevant.

  • Addition of cpp code files

How Has This Been Tested?

Programs have all been compiled and run to ensure they work.

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Firefox
  • npm run build
  • npm run preview

Checklist

Please delete options that are not relevant.

If involving code

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • My changes generate no new warnings

Folders and Files Added/Modified

Please list the folders and files added/modified with this pull request and delete options that are not relevant.

  • Added:
    • beyond-splashkit/Audio
    • beyond-splashkit/InputValidation

Additional Notes

Changes displayed are very basic. The plan is to expand this into a proper guide in the future

Copy link

@matt439 matt439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this guide is a great idea! My personal experience after SIT102 was that I wanted to learn more about how I could make my own games without SplashKit. However, all the source code is abstracted away, which felt like a brick wall. I would have found this guide extremely useful as I tried to understand what it takes to draw graphics to the screen.

In terms of review, I only found some minor issues regarding formatting and value types. I have no doubt that this guide will help out many students who are looking to learn lower level coding.

Copy link

@matt439 matt439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues are now resolved. Looks great!

Copy link

@rmachu rmachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Simon! I have reviewed this pull request and noticed you've added a new Resource Bundle which is causing an error when trying to run it. Everything else looks good, your programs are well written and organised. Once made into a full guide I can see it being very useful for people who want to smoothly transition from coding with SplashKit to without it. :)

Copy link

@rmachu rmachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change, I approve this PR. Everything looks good.

@omckeon omckeon self-assigned this Dec 16, 2024
Copy link

@omckeon omckeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes to these guides to provide some set up instructions and updated the code into tabs and individual code files (to prepare for SK Online).

These programs were really well done, and the eye dropper program is really useful to see it all come together!

@omckeon omckeon merged commit 7d2df68 into thoth-tech:add/beyond-splashkit Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants