Skip to content

Conversation

@w0st
Copy link
Contributor

@w0st w0st commented Sep 16, 2018

Hello!

I've have a proposition for solving problems like this one: #1188

If your dashboard has a field which is a subclass of (or it is a) Administrate::Field::BelongsTo then these changes allows you sort by column inside associated record based on order option.

I would appreciate your comments

@w0st w0st force-pushed the enable-sort-by-association-attribute branch from cb1fb81 to ef12af2 Compare September 16, 2018 18:44
@nickcharlton
Copy link
Member

This is looking good! Do you think you'd be able to add some tests for this feature, too?

@horacio
Copy link

horacio commented Oct 23, 2019

@w0st Hello! I'm interested in helping completing this PR. Let me know if you'd like me to write the tests for this new functionality. Thanks!

@w0st
Copy link
Contributor Author

w0st commented Oct 24, 2019

Thanks for reminding me about this PR. I'll check the existing test suite in Administrate and notify you about the status. I remember that I spotted small problems with existing unit tests when I was creating this PR. I wanted to fix them before this.

@nickcharlton nickcharlton added bug breakages in functionality that is implemented sorting ordering things on dashboards labels Jan 2, 2020
@pablobm
Copy link
Collaborator

pablobm commented Feb 13, 2020

An alternative would be to implement #1506 (still in discussion; may not make it through).

@nickcharlton
Copy link
Member

@w0st, where you able to look at this one again?

I've not looked into #1506 properly myself, but what do you think about that when you compare it to this approach?

@pablobm
Copy link
Collaborator

pablobm commented Jul 9, 2022

Superseeded by #2208

@pablobm pablobm closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug breakages in functionality that is implemented sorting ordering things on dashboards

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants