Fix routes template indentation#3029
Open
tanakakc wants to merge 1 commit intothoughtbot:mainfrom
Open
Conversation
The routes template had extra indentation that resulted in
misaligned code when Rails' route() method applied its own
indentation. The generated routes looked like:
namespace :admin do
resources :users
root to: "users#index"
end
After this fix:
namespace :admin do
resources :users
root to: "users#index"
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The routes template generates misaligned code in
config/routes.rb:This happens because the template includes extra indentation that compounds with Rails'
route()method, which automatically adds indentation when injecting routes.Fix
Adjusted the indentation in
routes.rb.erbso that the generated output is properly aligned:Tests
All existing route generator specs pass.