Replace Cucumber with RSpec acceptance specs#514
Merged
Conversation
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
derekprior
force-pushed
the
dp-acceptance-specs
branch
from
f7a135c to
4eee077
Compare
Contributor
There was a problem hiding this comment.
If example raise an exception, there's a chance that line 11 won't get run, right? How about using the block version of chdir?
Contributor
There was a problem hiding this comment.
Not sure if it matters much though, but I assume that your CWD will leak to the next run.
Contributor
Author
There was a problem hiding this comment.
I didn't know about or had forgotten the block version. Thanks.
The replacement spec does much the same as the features were doing before, but in a (hopefully) more maintainable manner. We generate a fresh rails app, install clearance, and run clearance's generated specs. I kept the acceptance spec in its own suite because the output of it is a bit odd and I wanted it separate from our usual tests. It will output the results of the generated specs followed by the result of the single acceptance spec.
derekprior
force-pushed
the
dp-acceptance-specs
branch
from
4eee077 to
ed6f8f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replacement spec does much the same as the features were doing before, but
in a (hopefully) more maintainable manner. We generate a fresh rails app,
install clearance, and run clearance's generated specs.
I kept the acceptance spec in its own suite because the output of it is a bit
odd and I wanted it separate from our usual tests. It will output the results
of the generated specs followed by the result of the single acceptance spec.