Handle Fixnums as string fields - #21
Conversation
There was a problem hiding this comment.
Nit pick - can you change the integer classes to number?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah sure, I misread the simple form class. I thought it had applied integer.
There was a problem hiding this comment.
Actually, here's the output from a simple form integer field.
<div class="input integer optional coupon_usages_allowed">
<label class="integer optional" for="coupon_usages_allowed"></label>
<input class="numeric integer optional" id="coupon_usages_allowed" name="coupon[usages_allowed]" step="1" type="number">
</div>Would you like it to follow that more closely? IE: integer on the wrapping div and label, and numeric and integer on the input?
There was a problem hiding this comment.
Yeah, ideally. I got lazy with the inputs and have just been copying them, but at some point I'll probably have simple_form regenerate them, and possibly add that as a dependency for testing and just build up a form properly. Maybe.
|
Great looks good. |
|
Rebased/merged. This change is now available in v0.0.6. |
|
@derekprior You were looking for this a couple days ago as well, I believe. |
No description provided.