Don't commit .bundle or vendor/bundle into update branches#4
Merged
Conversation
\`git add -A\` was staging bundler files that \`ruby/setup-ruby\` writes into the workspace (.bundle/config, vendor/bundle/). These got committed into the first importmap branch. On the next checkout back to origin/main, git deleted them — and with the bundle path config and cached gems gone, subsequent \`bin/importmap pin\` calls failed with "Could not find gems". Stage only the paths \`bin/importmap pin\` is expected to modify: \`config/importmap.rb\` and \`vendor/javascript/\` (for vendoring mode).
neilvcarvalho
force-pushed
the
nc/unstage-bundle-files
branch
from
6d4f577 to
8efe959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`git add -A` was staging bundler files that `ruby/setup-ruby` writes into the workspace (.bundle/config, vendor/bundle/). These got committed into the first importmap branch. On the next checkout back to origin/main, git deleted them — and with the bundle path config and cached gems gone, subsequent `bin/importmap pin` calls failed with "Could not find gems".
Unstaging both paths after `git add -A` keeps the commits clean and leaves bundler's environment intact across branch switches.