Skip to content

Update package versions#156

Merged
Rifdhan merged 1 commit into
mainfrom
update-package-versions
May 20, 2026
Merged

Update package versions#156
Rifdhan merged 1 commit into
mainfrom
update-package-versions

Conversation

@Rifdhan
Copy link
Copy Markdown
Collaborator

@Rifdhan Rifdhan commented May 20, 2026

  • Update zod, agents, and hono packages to latest
  • Remove zod-to-json-schema package, as zod natively provides the necessary functionality
  • Refresh package-lock to pick up latest patch versions of all other packages
  • Install lodash + types as an explicit dependency
  • Small cleanups and other fixes after upgrades

- Update zod, agents, and hono packages to latest
- Remove zod-to-json-schema package, as zod natively provides
  the necessary functionality
- Refresh package-lock to pick up latest patch versions of all
  other packages
- Install lodash + types as an explicit dependency
- Small cleanups and other fixes after upgrades
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including Hono and Zod, adds Lodash, and removes the zod-to-json-schema package. It also refactors tool definitions and cleans up unused imports. Critical issues were identified regarding the use of non-existent package versions in package.json and the invocation of a non-existent z.toJSONSchema method. Additionally, it is recommended to access environment variables via the context object instead of process.env to ensure compatibility with the Cloudflare Workers runtime.

Comment thread package.json
Comment thread src/servers/tool-definitions.ts
Comment thread src/handlers.ts
@mouryabalabhadra
Copy link
Copy Markdown
Collaborator

@copilot please review

Copy link
Copy Markdown

Copilot AI commented May 20, 2026

@copilot please review

Here's a summary of the changes in this PR:

Dependency updates:

  • agents: ^0.2.14^0.13.1
  • hono: ^4.10.3^4.12.21
  • zod: ^3.24.3^4.4.3
  • Removed zod-to-json-schema (zod v4 now provides z.toJSONSchema() natively)
  • Added lodash + @types/lodash as explicit dependencies
  • Refreshed package-lock.json for all packages

Code cleanups:

  • src/servers/tool-definitions.ts: Replaced all zodToJsonSchema(...) calls with z.toJSONSchema(...) and removed unused type aliases (ToolInput, ToolOutput)
  • src/handlers.ts: Removed unused imports (AuthRequest, Span, context, trace, any); added as string cast for process.env.OPEN_AI_TOKEN to satisfy Hono's stricter types
  • src/servers/mcp-server-base.ts: Removed unused ToolSchema import
  • test/handlers.spec.ts: Removed unused waitOnExecutionContext and ThoughtSpotMCP imports

Validation: All 648 tests pass and Biome linting reports no issues.

@Rifdhan Rifdhan merged commit a28abff into main May 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants