SCAL-281438 Fallback to user asked query if getRelevantQuestion fails

[shikharbsar]

• Currently if the tool call fails the whole analysis stops
• Added fallback to resume the analysis
• Also updated all spans to have instance url and userGUIDs

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Summary of Changes

Hello @shikharbsar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the resilience of the system by introducing a fallback mechanism for the getRelevantQuestion tool. If the tool call fails, the system will now gracefully return the user's original query, preventing a complete stoppage of analysis. Concurrently, the changes enhance the system's observability by ensuring that all relevant tracing spans are enriched with crucial context such as instance URLs and user GUIDs, providing more comprehensive diagnostic information.

Highlights

• Fallback Mechanism: Implemented a fallback for getRelevantQuestion failures, ensuring the system returns the original user query as structured content instead of halting analysis.
• Enhanced Tracing: Updated tracing spans to consistently include instance_url and userGUIDs for improved observability across various response types.
• Span Initialization Refactor: Standardized span initialization in BaseMCPServer's response creation methods by using this.initSpanWithCommonAttributes() for consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fallback mechanism for when the getRelevantQuestion tool call fails, preventing the analysis from stopping. It also standardizes OpenTelemetry span initialization to include common attributes like instance_url and userGUID. My review focuses on the new fallback logic. I've identified a critical issue where the fallback response does not adhere to the tool's output schema, which could break consumers. I've also noted a minor inconsistency in span initialization. A code suggestion is provided to address both points.