SCAL-298120 Support DATE_TIME and TIME data types in underlying data querie

[shivam-kumar-ts]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily introduces temporary debugging console.log statements within the AnswerService to facilitate the investigation of an issue, likely related to underlying data point retrieval and column processing. Additionally, it includes minor JSDoc formatting corrections to improve documentation clarity.

Highlights

• Debugging Enhancements: Extensive console.log statements were added across several methods within the AnswerService class, particularly in getUnderlyingDataForPoint, getSelectedPointsForUnderlyingDataQuery, and addPointFromColVal, to aid in debugging data retrieval and processing logic.
• JSDoc Formatting Corrections: Minor formatting issues in JSDoc comments were resolved, including adding spaces around the pipe character in @version tags and completing a code block example with a missing closing backtick sequence.

Changelog

• src/utils/graphql/answerService/answerService.ts
  • Added numerous console.log statements for debugging purposes in getUnderlyingDataForPoint, getSelectedPointsForUnderlyingDataQuery, and addPointFromColVal.
  • Corrected spacing in JSDoc @version tags.
  • Added a missing closing backtick sequence to a JSDoc code example.

Activity

• No human activity (comments, reviews) has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@445

commit: 05d3432

[gemini-code-assist]

Code Review

This pull request is primarily for testing purposes, introducing several console.log statements for debugging within AnswerService. However, these console.log statements in answerService.ts leak sensitive information, such as user data points and session identifiers, to the browser console. This poses a significant security risk if merged into production, as it exposes PII and business data to anyone with access to the browser's developer tools. It is crucial to remove all console.log statements before merging to prevent this data leakage and maintain a clean codebase. Additionally, the PR includes minor documentation formatting updates.

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication