Skip to content

SCAL-302303: Update TSE SDK for end of life of Sage Embed#475

Merged
mouryabalabhadra merged 2 commits intomainfrom
SCAL-302303
Mar 26, 2026
Merged

SCAL-302303: Update TSE SDK for end of life of Sage Embed#475
mouryabalabhadra merged 2 commits intomainfrom
SCAL-302303

Conversation

@mouryabalabhadra
Copy link
Copy Markdown
Collaborator

No description provided.

@mouryabalabhadra mouryabalabhadra requested a review from a team as a code owner March 24, 2026 01:02
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the TSE SDK by completely removing the SageEmbed component and all its associated code, configurations, and documentation. This change aligns the SDK with the end-of-life status of Sage Embed, streamlining the codebase and removing deprecated functionality. The removal impacts various parts of the SDK, including core embed logic, React components, error messages, and event handling, ensuring a cleaner and more focused API surface for developers.

Highlights

  • Sage Embed Removal: The SageEmbed component, its associated configuration (SageViewConfig), and all related files and references have been completely removed from the SDK due to its end-of-life.
  • API and Event Clean-up: All API parameters, embed events (like SageEmbedQuery and SageWorksheetUpdated), and configuration properties (e.g., suppressSageEmbedBetaWarning) specifically tied to SageEmbed have been deprecated and removed.
  • Test Suite Updates: Dedicated test files and individual test cases for SageEmbed have been deleted, ensuring the test suite accurately reflects the current SDK components.
  • Documentation and Examples: Documentation comments and code examples across the SDK have been updated to remove references to SageEmbed, providing accurate guidance for current embed components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@475

commit: 849cc12

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated SageEmbed component. While the removals are largely correct, a critical issue was found where necessary imports were removed from a test file, which could break the build. This issue has been flagged for correction.

@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Mar 25, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mouryabalabhadra mouryabalabhadra merged commit cb01842 into main Mar 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants