SCAL-315058: isReadyForRenderPromise gate never resolves + null-safety in init path

[mouryabalabhadra]

No description provided.

[mouryabalabhadra]

@copilot review the pr

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@545

commit: e0cd2ae

[gemini-code-assist]

Code Review

This pull request refactors the initialization and pre-rendering lifecycle of the ThoughtSpot embed SDK, ensuring that iframe replacement waits for initialization to complete and that initialization status is correctly tracked as a boolean. It also adds comprehensive unit tests for these lifecycle states. The review feedback highlights two critical issues in src/embed/ts-embed.ts where initialization failures are handled unsafely: first, an unavailable embedConfig in afterInit is silently ignored rather than throwing an error, which leads to downstream crashes; second, the initialization promise chain swallows errors in its .catch block, allowing downstream processes to proceed with a broken state instead of properly rejecting.

[Copilot]

@copilot review the pr

Reviewed the current PR changes and I don’t see any actionable issues in the patch. I also ran targeted validation on the touched area: npx jest -c jest.config.sdk.js --runInBand --coverage=false src/embed/base.spec.ts src/embed/ts-embed.spec.ts passed, and npx eslint on the touched files reported only warning-level comment-length findings.