Modernize packaging#339
Open
Zeitsperre wants to merge 11 commits into
Open
Conversation
Coverage Report for CI Build 26539512679Coverage increased (+0.02%) to 66.791%Details
Uncovered Changes
Coverage Regressions8 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several warnings and inconsistencies that are evident when examining the conda package and the testing output:
This also addresses some issues in the GitHub workflows:
source_checkjob was installingblackandisortbut not running them.pyproject.toml.Changes
$ spotpyto work properly from the command line (clickis now a core dependency).source_checkis nowlint: Linting libraries are now installed and run using--checkbuild_sdistis nowtest_buildblackandisortchecks are now enforced, and the code base has been adapted to latest versions.licenseandlicense-filesmetadata fields have been updated to be consistent withPEP 635.setup.pyhas been removed from theMANIFEST.in(deleted long ago).Breaking Changes
The library now uses
PEP 735for installing testing and linting libraries. These groupings of dependencies are installed via:The
testrecipe currently includes libraries to run optional components as well as libraries to run tests, so these still need to be split up a bit.Relevant PEPs:
What's missing?
pytest(perhaps for another PR)