feat(UrlJob): add url_for_human option#590
Closed
huxiba wants to merge 1 commit into
Closed
Conversation
when url is api, use url_for_human in report, so click the link in report will show the content that we want.
thp
requested changes
Dec 5, 2020
Owner
thp
left a comment
thp
left a comment
There was a problem hiding this comment.
Good idea, but I'm not too happy with the name. Maybe url_in_reports? Or report_url or url_for_report?
Owner
|
Implemented slightly differently ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when url is api, use url_for_human in report, so click the link in report will show the content that we want.