[pull] master from kevoreilly:master #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L) (#2905) * Fix case-sensitive platform comparison in Azure VMSS Platform comparison was case-sensitive, causing tasks to fail when platform tag used different casing (e.g., 'Windows' vs 'windows'). Fix: Use .lower() on both sides of comparison. File: modules/machinery/az.py Lines: ~660 * Fix SQL NULL handling in options_not_like filter Tasks with NULL or empty 'options' were not scheduled because SQL 'NULL NOT LIKE x' returns NULL (not TRUE). Fix: Import or_() and explicitly check for NULL and empty string. File: lib/cuckoo/core/database.py Lines: ~58 (import), ~2100 (fix) * Fix 7 critical Azure VMSS zero-scale bugs This commit combines 7 interdependent fixes for az.py: 1. VM provisioning timing (retry loop: 12×5s) 2. Scaling-flag race condition (add scaling_lock) 3. Import TASK_RUNNING for task counting 4. VMs deleted while tasks running (count PENDING+RUNNING) 5. Scaling flag deadlock (finally block) 6. Placeholder duplicate key (session.flush) 7. Zero-scale placeholder check (machine.reserved) All fixes tested together in production for 2 weeks. File: modules/machinery/az.py Lines: Multiple locations (~26, ~96, ~444, ~641, ~687, ~1126, ~1381)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )