[pull] master from jquast:master#22
Merged
pull[bot] merged 1 commit intothreatcode:masterfrom Mar 2, 2026
Merged
Conversation
First Linemode fix, that kludge was not correctly detected. WILL SGA and DO SGA do not really specify direction. It is a server's responsibility (WILL SGA) to suppress a GA. But RFC wording is unclear about this, and so it can be implemented [either way and often is! 50/50](https://muds.modem.xyz/statistics.html#telnet-option-negotiation). I believe either inetutils-telnetd or bsd4.4-derived telnetd sends both WILL and DO SGA and one of them has a long explanatory comment about it, that if i recall some popular telnet made a mistake with SGA, and so the workaround is to do the same as they do -- to support both directions to mean the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )