[pull] main from VirusTotal:main#149
Merged
Merged
Conversation
Now configuration is stored in the state of the language server. The configuration is resolved with `workspace.didChangeConfiguration` LSP method. VS Code always sends all `YARA.*` configuration attributes after LSP communication is initialized and when the configuration changes using this LSP method. This is most cheaper than calling `workspace.configuration` for specific language feature configuration every time. Additionally, the language server now caches the entire workspace by storing a CST for each YARA file. This still can be disabled in YARA LS configuration in the editor settings. For maintaining consistency between cache and FS state it is leveraging LSP method `workspace/didChangeWatchedFiles` to watch YARA files that were not opened in the editor but were changed (e.g. git commands or any other manipulation from the terminal...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )