Skip to content

check on mnemonic when confirming seed #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlaaElattar merged 4 commits into from
Nov 24, 2024
Merged

check on mnemonic when confirming seed #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f12bae5
check on mnemonic when confirming sed
AlaaElattar Oct 31, 2024
8be6348
Merge branch 'development' of github.com:threefoldtech/threefold_conn…
AlaaElattar Nov 19, 2024
9e9c457
move validation logic inside validateSeedWords
AlaaElattar Nov 19, 2024
5efec30
fix condition
AlaaElattar Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/screens/mobile_registration_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class _MobileRegistrationScreenState extends State<MobileRegistrationScreen> {
});

bool seedWordConfirmationValidation = validateSeedWords(
_registrationData.phrase, seedConfirmationController.text);
_registrationData.phrase, seedCheckValue);

if (seedWordConfirmationValidation) {
setState(() {
Expand Down
5 changes: 4 additions & 1 deletion app/lib/services/tools_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ bool validateSeedWords(String seed, String confirmationWords) {
List<String> seedWords = seed.split(' ');

// if length is not correct return already here
if (words.length != 3) return false;
if (words.length < 3) return false;
if (words.length < 3 || words.toSet().length < 3) {
return false;
}

for (final String word in words) {
// check every word in list against the seed
Expand Down