add/edit stellar address in farm#781
Merged
Merged
Conversation
zaelgohary
requested changes
Dec 1, 2024
Contributor
zaelgohary
left a comment
zaelgohary
left a comment
There was a problem hiding this comment.
I could edit a stellar address with an invalid value. I think we should validate the address before adding/editing.
zaelgohary
reviewed
Dec 1, 2024
Contributor
|
Clicking edit and navigating to the homepage without saving leaves the farming page stuck in the editing state. |
…ect into development_add/edit_stellar
Contributor
Author
|
Contributor
Author
tried to reproduce it but didn't happen |
AhmedHanafy725
requested changes
Dec 11, 2024
…ect into development_add/edit_stellar
zaelgohary
approved these changes
Dec 11, 2024
| } | ||
|
|
||
| void validateStellarAddress(String address) async { | ||
| setState(() { |
Contributor
There was a problem hiding this comment.
please trim the address before start validating
AhmedHanafy725
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested Scenarios: