Skip to content

Bridge Stellar to Solana#811

Merged
zaelgohary merged 32 commits into
developmentfrom
development_bridge_solana
Mar 5, 2025
Merged

Bridge Stellar to Solana#811
zaelgohary merged 32 commits into
developmentfrom
development_bridge_solana

Conversation

@zaelgohary
Copy link
Copy Markdown
Contributor

@zaelgohary zaelgohary commented Dec 19, 2024 •
edited
Loading

Changes

  • Edit bridge design to include Solana
  • Refactor bridge

Related Issues

Tested Scenarios

  • Swap multiple chains (TFChain <> Stellar, Stellar => Solana)
  • Change the selected chain and review the fee changes
  • Solana should never be in the left chains
  • To address should be removed on chain change
  • 'To' label should be changed to 'Associated Token Address' in case of Solana
  • Contact icon should be hidden if Solana is current to chain
  • Swap should be disabled if Solana is chosen
  • Swap should be disabled if the to chain is Stellar and the wallet doesn't have Stellar in its assets
  • Should only be able to bridge to Solana in case from chain is Stellar
  • Test fee in all chains (Solana: 50.01, Stellar: 1.1, TFChain: 1.01)

@zaelgohary
Edit bridge design to include solana, refactor bridge
773862d
@zaelgohary
Fix left & right chain labels, edit selectedChain
04753ae
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
0a95b71 
…old_connect into development_bridge_solana
@zaelgohary
Fix swap styling, fix swapping, exclude left chain from right dropdown
02ef093
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
f2650bc 
…old_connect into development_bridge_solana
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
5c3b1e0 
…old_connect into development_bridge_solana
@zaelgohary
Filter dropdowns based on selected chains, add selected chain default…
c2982a7 
… value, fix swapping, refactor dropdown
@zaelgohary
Update current operation on chain change
0db5400
@zaelgohary
Add Solana validation, simple refactor
eeaee3d
@zaelgohary
Add Solana fee, edit validation
d50c402
@zaelgohary
Remove unused enum
5ec5371
@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/threef…
d99ee11 
…old_connect into development_bridge_solana
@zaelgohary
Fix fee & bridge validation
97669c2
@zaelgohary
Fix fee & solana validation, add memoHash
12b02ec
@zaelgohary
Revert precommit changes
1173b34
@zaelgohary
Revert precommit changes, make memHash optional positional arg
a099099
@zaelgohary
Revert testnet changes
937634f
@zaelgohary zaelgohary marked this pull request as ready for review January 28, 2025 11:17
AlaaElattar
AlaaElattar reviewed Jan 29, 2025
View reviewed changes
Comment thread app/lib/widgets/wallets/swap_transaction_widget.dart
@AlaaElattar
Copy link
Copy Markdown
Contributor

AlaaElattar commented Jan 29, 2025

  • As it requires to have XLMs, I think we should add hint or note to notify user about having them.

@zaelgohary zaelgohary marked this pull request as draft January 29, 2025 15:06
@zaelgohary
Copy link
Copy Markdown
Contributor Author

zaelgohary commented Jan 29, 2025

Will keep this drafted till bridge is on mainnet.

@xmonader
Copy link
Copy Markdown
Contributor

xmonader commented Jan 30, 2025 •
edited
Loading

It can be disabled with feature flags no?

@zaelgohary
Copy link
Copy Markdown
Contributor Author

zaelgohary commented Jan 30, 2025

It can be disabled with feature flags no?

Yes but not implemented. Should I?

@zaelgohary zaelgohary marked this pull request as ready for review March 4, 2025 11:21
@zaelgohary zaelgohary requested a review from AlaaElattar March 4, 2025 11:21
@AlaaElattar
Copy link
Copy Markdown
Contributor

AlaaElattar commented Mar 4, 2025

  • In the tested scenarios u mentioned that Contact icon should be hidden if Solana is current to chain, but this didn't happen.

@zaelgohary zaelgohary changed the title Bridge Solana Bridge Stellar to Solana Mar 4, 2025
@AlaaElattar
Copy link
Copy Markdown
Contributor

AlaaElattar commented Mar 4, 2025

  • In the tested scenarios u mentioned that Contact icon should be hidden if Solana is current to chain, but this didn't happen.
  • Also check the transfer fee of Solana.

AhmedHanafy725
AhmedHanafy725 reviewed Mar 4, 2025
View reviewed changes
Comment thread app/lib/screens/wallets/bridge.dart Outdated
AlaaElattar
AlaaElattar previously approved these changes Mar 5, 2025
View reviewed changes
@zaelgohary
Copy link
Copy Markdown
Contributor Author

zaelgohary commented Mar 5, 2025

I tested mainnet bridge and it works fine.

image

@zaelgohary zaelgohary merged commit 1ffc289 into development Mar 5, 2025
@zaelgohary zaelgohary deleted the development_bridge_solana branch March 5, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

+1 more reviewer

@AlaaElattar AlaaElattar AlaaElattar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zaelgohary @AlaaElattar @xmonader @AhmedHanafy725