Use wallet provider instead of fn propagation#822
Merged
Conversation
zaelgohary
changed the title
Base automatically changed from
development_refactor_wallet_provider
to
development
December 29, 2024 14:49
…old_connect into development_use_wallet_provider
AhmedHanafy725
requested changes
Dec 30, 2024
Contributor
AhmedHanafy725
left a comment
AhmedHanafy725
left a comment
There was a problem hiding this comment.
- The provider should have a method for editing the wallet name. We shouldn't wait until the reload balance is called to update the name.
- Adding a new wallet doesn't use the provider.
…old_connect into development_use_wallet_provider
Contributor
Author
I added a watcher to the wallet to reload the details on any change. |
AhmedHanafy725
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
Tested Scenarios
A list of scenarios tried to match the deliverables