Skip to content

support kyc for each wallet#827

Merged
AlaaElattar merged 42 commits into
developmentfrom
development_kyc_wallets
Jan 27, 2025
Merged

support kyc for each wallet#827
AlaaElattar merged 42 commits into
developmentfrom
development_kyc_wallets

Conversation

@AlaaElattar
Copy link
Copy Markdown
Contributor

@AlaaElattar AlaaElattar commented Dec 25, 2024

Changes

  • Moved KYC verification from identity page to be in wallets.
  • each wallet can be verified separately.
  • If wallet is verified and was imported somewhere else, it will appear as verified also with its verified data.

Related Issues

Tested Scenarios

A list of scenarios tried to match the deliverables

@AlaaElattar AlaaElattar marked this pull request as draft December 25, 2024 12:24
@AlaaElattar AlaaElattar marked this pull request as ready for review January 8, 2025 13:05
@zaelgohary
Copy link
Copy Markdown
Contributor

Workflow needs to be fixed.

@AlaaElattar AlaaElattar marked this pull request as draft January 15, 2025 08:02
@AlaaElattar AlaaElattar marked this pull request as ready for review January 16, 2025 10:55
Copy link
Copy Markdown
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dialog size is too big

}
}

Future<void> saveCorrectVerificationStates(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you remove this method?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we don't need it anymore. what do think ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's useful to get the correct state if the storage is deleted and the account is recovered

Comment thread app/lib/widgets/wallets/wallet_card.dart Outdated
Comment thread app/lib/screens/wallets/wallet_info.dart Outdated
Comment thread app/lib/screens/wallets/wallet_info.dart
Comment thread app/lib/screens/wallets/wallet_info.dart Outdated
Comment thread app/lib/screens/wallets/wallet_info.dart Outdated
Comment thread app/lib/screens/wallets/wallet_info.dart Outdated
Comment thread app/lib/screens/wallets/wallet_info.dart Outdated
Comment thread app/lib/screens/wallets/wallet_info.dart Outdated
Comment thread app/lib/widgets/kyc_widget.dart Outdated
@AlaaElattar AlaaElattar marked this pull request as draft January 20, 2025 07:21
@AlaaElattar AlaaElattar marked this pull request as ready for review January 22, 2025 11:30
Comment thread app/lib/models/wallet.dart Outdated
}
}

Future<void> saveCorrectVerificationStates(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's useful to get the correct state if the storage is deleted and the account is recovered

Comment thread app/lib/widgets/wallets/wallet_card.dart Outdated
@AlaaElattar AlaaElattar merged commit d379ad6 into development Jan 27, 2025
@AlaaElattar AlaaElattar deleted the development_kyc_wallets branch January 27, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants