Skip to content

fix adding existing stellar secret#843

Merged
AlaaElattar merged 3 commits into
developmentfrom
development_stellar_secret
Jan 19, 2025
Merged

fix adding existing stellar secret#843
AlaaElattar merged 3 commits into
developmentfrom
development_stellar_secret

Conversation

@AlaaElattar
Copy link
Copy Markdown
Contributor

@AlaaElattar AlaaElattar commented Jan 8, 2025

Changes

  • The stellar secret of 12 mnemonic wallet was added again without an error.
  • Added a condition to check the provided stellar secret with existing ones

Related Issues

Tested Scenarios

  • Tested with secret seed of 12 mnemonic account.
  • Tested with secret seed of 24 mnemonic account.

Comment thread app/lib/widgets/wallets/add_wallet.dart
Copy link
Copy Markdown
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a wallet using a 12-word mnemonic, then used the same Stellar secret to import a new wallet after removing the first one. Despite another wallet with the same secret already existing, I was able to import the same wallet using the 12-word mnemonic.

image

image

Copy link
Copy Markdown
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous comment is a known issue.

@AlaaElattar AlaaElattar merged commit 6f79360 into development Jan 19, 2025
@AlaaElattar AlaaElattar deleted the development_stellar_secret branch January 19, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants