Skip to content

improve phone number verification counter#846

Merged
zaelgohary merged 10 commits into
developmentfrom
development_mobile_counter
Feb 3, 2025
Merged

improve phone number verification counter#846
zaelgohary merged 10 commits into
developmentfrom
development_mobile_counter

Conversation

@AlaaElattar
Copy link
Copy Markdown
Contributor

@AlaaElattar AlaaElattar commented Jan 15, 2025

Changes

  • Updated phone number counter to count live.

Related Issues

Tested Scenarios

  • clicked verify and waited for the timer and was counting right.
  • clicked verify then leaved the page and return again, the counter was counting right.

image

image

Comment thread app/lib/screens/identity_verification_screen.dart Outdated
@AlaaElattar AlaaElattar marked this pull request as draft January 27, 2025 15:16
@AlaaElattar AlaaElattar marked this pull request as ready for review January 28, 2025 11:16
Comment thread app/lib/screens/identity_verification_screen.dart Outdated
@zaelgohary
Copy link
Copy Markdown
Contributor

The dialogue style needs to be fixed.

image

@zaelgohary
Copy link
Copy Markdown
Contributor

I can't edit my phone after clicking verify. Even after the counter is finished, I cannot edit my phone. What if the user entered the wrong phone number and wants to change it as he can't verify?

@AlaaElattar AlaaElattar marked this pull request as draft February 2, 2025 09:13
@AlaaElattar AlaaElattar marked this pull request as ready for review February 2, 2025 14:16
Comment thread app/lib/widgets/phone_widget.dart Outdated
Comment thread app/lib/widgets/phone_widget.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants