Skip to content

Hide show phrase#995

Merged
zaelgohary merged 3 commits into
developmentfrom
development_hide_show_phrase
Apr 16, 2025
Merged

Hide show phrase#995
zaelgohary merged 3 commits into
developmentfrom
development_hide_show_phrase

Conversation

@zaelgohary
Copy link
Copy Markdown
Contributor

@zaelgohary zaelgohary commented Apr 10, 2025

Changes

  • Hide show phrase, edit savePhrase to set without removing previous value, add missing awaits in saveRegistration

Related Issues

Tested Scenarios

  • Set phrase to empty

@zaelgohary zaelgohary marked this pull request as draft April 13, 2025 10:11
@zaelgohary
Copy link
Copy Markdown
Contributor Author

I suspect that the issue happened because of the missing awaits in all user fields in mobile registration page. Anyway, this is already fixed in this PR.

screenrecording04-11-2025-13-4_1hv4gve.mp4

@zaelgohary zaelgohary marked this pull request as ready for review April 13, 2025 20:23
@AhmedHanafy725
Copy link
Copy Markdown
Contributor

This could happen because of this line
https://github.com/threefoldtech/threefold_connect/blob/b46b76c08045b5381547b787cdc03c85dbfda6b9/app/lib/screens/identity_verification_screen.dart#L59

The widget gets the user info in the initState without await, so it might take time based on the I/O speed.
IMO, we should show a loading till the data is retrieved.

Comment thread app/lib/screens/identity_verification_screen.dart Outdated
Comment thread app/lib/screens/identity_verification_screen.dart Outdated
@zaelgohary zaelgohary merged commit 26c533d into development Apr 16, 2025
2 checks passed
@zaelgohary zaelgohary deleted the development_hide_show_phrase branch April 16, 2025 14:45
AlaaElattar pushed a commit that referenced this pull request Apr 28, 2025
AlaaElattar added a commit that referenced this pull request Apr 30, 2025
* WIP: adding notifications pgk

* fix ios issue and show notification with offline nodes

* remove unused import && undo changes in podfile.lock

* WIP: adding permissions for android

* WIP: downgrade background_fetch

* WIP: downgrade background_fetch

* clear cached background_fetch

* specify ndk version

* undo nkd version setup

* WIP: add debug logs

* WIP: debug background_fetch version

* update pubspec.lock

* update build.gradle

* WIP: remove gradle cache

* fix command

* WIP: Update build.gradle

* WIP: fix space

* undo latest commit

* add maven url in build.gradle

* Add close button for confirmation dialog (#976)

* add close button for confirmation dialog

* add cancel btn in bridge also

* Handle non-loading for delete wallet (#973)

* add timeout 1 min for deleting wallet

* update error messages

* Prevent PIN Entry Attempts During 30 Second Lockout Period  (#989)

* keep user locked after the many attempts

* update pin screen to include live counter

* Fix transactions paginations (#992)

* Fix transactions pagination, use pagingToken instead of offset

* Edit listTransactions to return stream instead of list

* Update stellar client ref

* handle duplicated daily (#986)

* Update the packages version for background_fetch & flutter_local_notifications

* Request to enable the notification service on android

* Revert the changes in the wrong manifest file

* Update the gradle repos

* Update build gradle dependencies

* Update the manifest permissions

* only show notifications for nodes down last 2 days && group notifications

* remove unused import

* update checking nodes for last 7 days

* Update app/lib/services/background_service.dart

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

* apply pr comments && apply the exponential notification

* handle notification grouping

* handled tapping on notification

* Hide show phrase (#995)

* Handle duplicated contacts in favorite List (#983)

* handle duplicated contacts

* undo latest solution

* fix adding duplicated wallet in fav list

* Fixed the duplicated contacts issue

* update condition when editing address

* Fix auth timeout routing (#1000)

* Creating app lifecycle observer and use it in main.dart w navigator key, Replace Navigator routes w  navigator key

* Remove unused code

* Revert navigator key changes from screens

* Revert main screen changes

* fix ios issue and show notification with offline nodes

* update pubspec.lock

* fix workflow

* fix equation && workflow

* undo the equation

* fixed time conversion

---------

Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>
Co-authored-by: AhmedHanafy725 <hanafya@incubaid.com>
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants