Skip to content

Docker for QSFS#17

Merged
robvanmieghem merged 23 commits intomasterfrom
qsfs-docker
Mar 6, 2023
Merged

Docker for QSFS#17
robvanmieghem merged 23 commits intomasterfrom
qsfs-docker

Conversation

@OmarElawady
Copy link
Copy Markdown
Contributor

@maxux
Copy link
Copy Markdown
Collaborator

maxux commented Dec 6, 2021

I see you using always using backticks for shell execution in your script.
You should move to $(...) :)
http://mywiki.wooledge.org/BashFAQ/082

@OmarElawady OmarElawady marked this pull request as draft December 7, 2021 13:59
@OmarElawady
Copy link
Copy Markdown
Contributor Author

I see you using always using backticks for shell execution in your script. You should move to $(...) :) http://mywiki.wooledge.org/BashFAQ/082

Thanks! didn't know that, laziness was my only motive.

Converting to a draft pull requests until relevant projects are released (to update the versions).

@muhamadazmy muhamadazmy marked this pull request as ready for review February 24, 2023 10:48
@robvanmieghem robvanmieghem force-pushed the qsfs-docker branch 2 times, most recently from 7331051 to eebec3c Compare March 3, 2023 13:03
@robvanmieghem robvanmieghem merged commit 63338b8 into master Mar 6, 2023
@robvanmieghem robvanmieghem deleted the qsfs-docker branch March 6, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants